From: Florian Müllner <fmuellner@gnome.org>
Date: Sat, 20 Feb 2021 23:23:07 +0000 (+0100)
Subject: workspaceThumbnails: Immediately initialize should-show
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~616^2^2~218
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=4eb31e4e18bb6861383e9a78c244a356e854682a;p=gnome-shell.git

workspaceThumbnails: Immediately initialize should-show

At the moment, we only get the initial :should-show value when populating
the thumbnails. That only happens when entering the overview, so any
listeners to notify::should-show will perceive it as a change rather
than an initialization, which can result in unwanted transitions.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1735>
---

diff --git a/js/ui/workspaceThumbnail.js b/js/ui/workspaceThumbnail.js
index fb25f6cb1..e54e8ab1d 100644
--- a/js/ui/workspaceThumbnail.js
+++ b/js/ui/workspaceThumbnail.js
@@ -684,6 +684,7 @@ var ThumbnailsBox = GObject.registerClass({
         this._settings = new Gio.Settings({ schema_id: MUTTER_SCHEMA });
         this._settings.connect('changed::dynamic-workspaces',
             () => this._updateShouldShow());
+        this._updateShouldShow();
 
         this._monitorsChangedId =
             Main.layoutManager.connect('monitors-changed', () => {
@@ -1010,8 +1011,6 @@ var ThumbnailsBox = GObject.registerClass({
             this._stateCounts[ThumbnailState[key]] = 0;
 
         this.addThumbnails(0, workspaceManager.n_workspaces);
-
-        this._updateShouldShow();
     }
 
     _destroyThumbnails() {